Subject: CVS commit: src/dist/iscsi/src
To: None <source-changes@NetBSD.org>
From: Greg Oster <oster@netbsd.org>
List: source-changes
Date: 11/30/2007 00:33:35
Module Name: src
Committed By: oster
Date: Fri Nov 30 00:33:35 UTC 2007
Modified Files:
src/dist/iscsi/src: parameters.c
Log Message:
We have 4 cases here: rx_answer, tx_answer, rx_offer, and tx_offer.
When determining what to put in to param->negotiated, it is *NOT*
sufficient to just pick one of offer_tx or offer_rx -- we may need to
use answer_rx or answer_tx as the negotiated parameter. Failure to
pay attention to which case we are handling means we will occasionally
get "old parameter values" stuffed into responses, resulting in
obscure behavior (such as getting luns mixed up after a normal
connection is made) that is very difficult to replicate.
To generate a diff of this commit:
cvs rdiff -r1.9 -r1.10 src/dist/iscsi/src/parameters.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.