CVS commit: src/usr.bin/make

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    src
Committed By:   rillig
Date:           Mon Feb  1 21:56:03 UTC 2021

Modified Files:
        src/usr.bin/make: parse.c
        src/usr.bin/make/unit-tests: var-op-assign.exp varname.exp

Log Message:
make: replace parse error "Need an operator" with better message

The previous error message is not easily understandable since it is
missing a crucial detail, the column where the operator is needed.
Without this information, the author of the makefile gets no useful
hint.  Furthermore, there are several types of operators in makefiles:

        the dependency operators ':', '!', '::',
        the variable assignment operators '=', '!=', '+=', '?=', ':=',
        the conditional operators '&&', '||', '!',
        the comparison operators '==', '!=', '>', '>=', '<', '<='.

This leaves too much ambiguity.

Replace this error message with "Invalid line type", which is more
generic, more accurate and thus less misleading.


To generate a diff of this commit:
cvs rdiff -u -r1.534 -r1.535 src/usr.bin/make/parse.c
cvs rdiff -u -r1.4 -r1.5 src/usr.bin/make/unit-tests/var-op-assign.exp
cvs rdiff -u -r1.9 -r1.10 src/usr.bin/make/unit-tests/varname.exp

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.