CVS commit: [netbsd-8] src

["Martin Husemann" <martin%netbsd.org@localhost>]

Module Name:    src
Committed By:   martin
Date:           Wed Aug  9 16:16:40 UTC 2023

Modified Files:
        src/distrib/sets/lists/debug [netbsd-8]: mi
        src/distrib/sets/lists/tests [netbsd-8]: mi
        src/libexec/ld.elf_so [netbsd-8]: Makefile symbol.c
        src/tests/libexec/ld.elf_so [netbsd-8]: Makefile
Added Files:
        src/libexec/ld.elf_so [netbsd-8]: hash.c hash.h
        src/tests/libexec/ld.elf_so [netbsd-8]: t_hash.c

Log Message:
Pull up following revision(s) (requested by riastradh in ticket #1886):

        distrib/sets/lists/debug/mi                     1.409 (patch)
        distrib/sets/lists/tests/mi                     1.1280 (patch)
        libexec/ld.elf_so/Makefile                      1.145-1.147 (patch)
        libexec/ld.elf_so/hash.c                        1.1
        libexec/ld.elf_so/hash.h                        1.1
        libexec/ld.elf_so/reloc.c                       1.118 (patch)
        libexec/ld.elf_so/rtld.c                        1.215 (patch)
        libexec/ld.elf_so/rtld.h                        1.145,1.147 (patch)
        libexec/ld.elf_so/symbol.c                      1.74-1.76 (patch)
        tests/libexec/ld.elf_so/Makefile                1.21 (patch)
        tests/libexec/ld.elf_so/t_hash.c                1.1

The SysV ABI specifies that the symbol hash function should return only 32
bits of hash. Unfortunately due to an implementation bu and the fact that
the return type is unsigned long which is 64 bits in LP64, this can fail
in some cases: "\xff\x0f\x0f\x0f\x0f\x0f\x12". See:
        https://maskray.me/blog/2023-04-12-elf-hash-function

>From Ed Maste @ FreeBSD:
        https://cgit.freebsd.org/src/commit/?id=29e3a06510823edbb91667d21f530d3ec778116d

Need to write Unit Tests for this.

Oops wrong mask.

ld.elf_so: Split SRCS onto multiple lines.
Makes updates easier.
No functional change intended.

ld.elf_so: Sort SRCS.
No functional change intended.

ld.elf_so: Split hash functions into a separate file.
This way we can test them in isolation.
No functional change intended.

ld.elf_so: Add some known-answer tests for hash functions.

Make sure the testing mechanism detects the traditional overflow bug.


To generate a diff of this commit:
cvs rdiff -u -r1.216.2.9 -r1.216.2.10 src/distrib/sets/lists/debug/mi
cvs rdiff -u -r1.752.2.10 -r1.752.2.11 src/distrib/sets/lists/tests/mi
cvs rdiff -u -r1.136.6.1 -r1.136.6.2 src/libexec/ld.elf_so/Makefile
cvs rdiff -u -r0 -r1.1.4.2 src/libexec/ld.elf_so/hash.c \
    src/libexec/ld.elf_so/hash.h
cvs rdiff -u -r1.67.6.2 -r1.67.6.3 src/libexec/ld.elf_so/symbol.c
cvs rdiff -u -r1.8.8.1 -r1.8.8.2 src/tests/libexec/ld.elf_so/Makefile
cvs rdiff -u -r0 -r1.1.4.2 src/tests/libexec/ld.elf_so/t_hash.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.