CVS commit: [netbsd-10] src

["Martin Husemann" <martin%netbsd.org@localhost>]

Module Name:    src
Committed By:   martin
Date:           Sun Nov 17 16:16:11 UTC 2024

Modified Files:
        src/distrib/sets/lists/debug [netbsd-10]: mi
        src/distrib/sets/lists/tests [netbsd-10]: mi
        src/sys/compat/netbsd32 [netbsd-10]: netbsd32_ioctl.c
        src/sys/sys [netbsd-10]: filedesc.h
        src/tests/kernel [netbsd-10]: Makefile
Added Files:
        src/tests/kernel [netbsd-10]: h_cloexec.c t_cloexec.c

Log Message:
Pull up following revision(s) (requested by riastradh in ticket #1007):

        tests/kernel/Makefile: revision 1.83
        sys/sys/filedesc.h: revision 1.71
        distrib/sets/lists/tests/mi: revision 1.1346
        tests/kernel/h_cloexec.c: revision 1.1
        tests/kernel/t_cloexec.c: revision 1.1
        sys/compat/netbsd32/netbsd32_ioctl.c: revision 1.122
        distrib/sets/lists/debug/mi: revision 1.454

tests/kernel/t_cloexec: New tests for close-on-exec.
Verified that the following tests fail on a netbsd-10 kernel:
- clonedev_posixspawn
- dup3_posixspawn
- fcntldupfd_posixspawn
PR kern/58822: close-on-exec is broken for dup3 and opening cloning
devices

sys/filedesc.h: Add a note about writing to ff_exclose.
No functional change intended -- just a reminder to avoid repeating a
class of bugs we've had.
PR kern/58822: close-on-exec is broken for dup3 and opening cloning
devices

netbsd32_ioctl: Use fd_set_exclose instead of open-coding it.
No functional change intended -- this just reduces unnecessary
copies of open-coded logic which, when copied incompletely, led to:
PR kern/58822: close-on-exec is broken for dup3 and opening cloning
devices


To generate a diff of this commit:
cvs rdiff -u -r1.394.2.14 -r1.394.2.15 src/distrib/sets/lists/debug/mi
cvs rdiff -u -r1.1238.2.18 -r1.1238.2.19 src/distrib/sets/lists/tests/mi
cvs rdiff -u -r1.120.4.1 -r1.120.4.2 src/sys/compat/netbsd32/netbsd32_ioctl.c
cvs rdiff -u -r1.70 -r1.70.2.1 src/sys/sys/filedesc.h
cvs rdiff -u -r1.70 -r1.70.2.1 src/tests/kernel/Makefile
cvs rdiff -u -r0 -r1.1.2.2 src/tests/kernel/h_cloexec.c \
    src/tests/kernel/t_cloexec.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.