CVS commit: src

["Robert Elz" <kre%netbsd.org@localhost>]

Module Name:    src
Committed By:   kre
Date:           Fri Dec 20 22:24:20 UTC 2024

Modified Files:
        src: build.sh

Log Message:
General code cleanup.   No operational change intended.

Mostly fix quoting, some missing quotes added, lots of meaningless
quotes removed (no guarantee of completeness in either of those).

Also get rid of one use of the obsolete test -o operator, and several
less than ideal uses of the test ! operator ... replace all that by
shell || and ! uses.

Don't use $@ in any context where field splitting cannot occur (also
avoid it in a couple of places where it would be defined, but isn't
actually wanted:
        echo "whatever: $@"
is technically OK, but is generally just a waste of everyone's time,
the shell passing a whole set of args to echo for it to combine
back into one line is pointless.   But X="$@" and using $@ in a
here doc are simply wrong.

The 80-column police visited during the update (just a couple of
hard cases managed to avoid detection).

Many extraneous use of sh \ line continuations removed when better
use of sh syntax means they're not required.

General cleanup of sh coding style (prefer clarity over white space
minimization).

If these changes cause any issues (aside from a small possibility of
slight layout changes in some error messages) that anyone is able
to observe, please let me know.


To generate a diff of this commit:
cvs rdiff -u -r1.385 -r1.386 src/build.sh

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.