Subject: Re: kernel disklabel messages
To: Jason Thorpe <thorpej@nas.nasa.gov>
From: Perry E. Metzger <perry@piermont.com>
List: tech-kern
Date: 08/17/1998 19:00:20
As I just said, I'm not convinced this should be printed at all if an
ioctl can be devised to provide the same data.

Jason Thorpe writes:
> On 17 Aug 1998 17:35:32 -0400 
>  rvb@sicily.odyssey.cs.cmu.edu wrote:
> 
>  > First, this is an x86 only issue; it is my doing to get more info for
>  > sysinst.  I guess there is a glitch in scsi sd that causes it to call
>  > disklabel three times (per disk?).  I'll look for this unless someone
>  > else gets to it first.
> 
> "How many opens are happening?"  This is going to happen whenever a disk
> is opened and there were no previously open parititions.  That's pretty
> annoying.
> 
> There should probably be some state kept in the cpu_disklabel, to prevent
> the warning from being issued more than once, and readdisklabel, etc.
> should probably take a "struct disk" as an argument, not a dev_t, so that
> the name of the disk can be printed.
> 
> Jason R. Thorpe                                       thorpej@nas.nasa.gov
> NASA Ames Research Center                            Home: +1 408 866 1912
> NAS: M/S 258-5                                       Work: +1 650 604 0935
> Moffett Field, CA 94035                             Pager: +1 650 940 5942