Subject: Re: CVS commit: syssrc
To: Manuel Bouyer <bouyer@antioche.lip6.fr>
From: Ben Harris <bjh21@netbsd.org>
List: tech-kern
Date: 10/15/2000 16:23:31
[ Moving to tech-kern: that's where this belongs ]
On Sun, 15 Oct 2000, Manuel Bouyer wrote:
> On Sun, Oct 15, 2000 at 02:46:00AM +0300, Ben Harris wrote:
> >
> > Module Name: syssrc
> > Committed By: bjh21
> > Date: Sat Oct 14 23:45:59 UTC 2000
> >
> > Modified Files:
> > syssrc/sys/dev/ic: wdc_upc.c
> >
> > Log Message:
> > Shuffle printfs around so they look right when we've got a drive attached.
>
> I didn't notice this file, but shouldn't this be somewhere else ?
> Maybe we need a sys/dev/upc ?
> sys/dev/ic should only have bus-independant code.
I think that depends on how you define "bus". The upc driver is for a
single chip of the usual PC super-IO variety, and calling it a bus seems
over the top. Do we really want a separate subdirectory for every
multi-function chip that might be attached to more than one bus?
If it would help, I could move all the code into upc.c -- the only reason
it's not there already is that I didn't know how to do the preprocessor
conditionals for this, and I do now.
It's notable that there is at least one other device that follows the same
pattern -- the depca device has an "le" built into it, but still warrants
a place in dev/ic.
--
Ben Harris <bjh21@netbsd.org>
Portmaster, NetBSD/arm26 <URL:http://www.netbsd.org/Ports/arm26/>