Subject: Re: Any objections? Patch to change routine to print ata dma modes for more than just pciide
To: Hubert Feyrer <hubert@feyrer.de>
From: Manuel Bouyer <bouyer@antioche.lip6.fr>
List: tech-kern
Date: 11/08/2000 14:45:26
--EVF5PPMfhYS0aIcm
Content-Type: text/plain; charset=us-ascii

On Wed, Nov 08, 2000 at 03:06:05AM +0100, Hubert Feyrer wrote:
> On Tue, 7 Nov 2000, Bill Studenmund wrote:
> > Subject says it all. Devices on more than just pciide (like the wdc
> > built into power macs) can support DMA. This patch moves the pretty-print
> > routine to wdc.c. Comments?
> 
> Feature request: can we actually print out UDMA/33, UDMA/66 and whatnot?
> It's nice to have the mode in numerical form, but  plain text would be
> nice, too. 

We could print it for the drives cap (e.g.:
wd0: drive supports PIO mode 4, DMA mode 2, Ultra-DMA mode 4 (Ultra/66)

But for the modes really used I don't think this makes sense (Ultra-DMA mode 1
isn't really Ultra/something).
The attached patch should do this. Bill, can you commit it at the same time
please ?

--
Manuel Bouyer, LIP6, Universite Paris VI.           Manuel.Bouyer@lip6.fr
--

--EVF5PPMfhYS0aIcm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=diff

--- wdc.c.orig	Wed Nov  8 14:43:11 2000
+++ wdc.c	Wed Nov  8 14:44:35 2000
@@ -1094,6 +1094,12 @@
 						continue;
 				if (!printed) {
 					printf("%s Ultra-DMA mode %d", sep, i);
+					if (i == 2)
+						printf(" (Ultra/33)");
+					else if (i == 4)
+						printf(" (Ultra/66)");
+					else if (i == 5)
+						printf(" (Ultra/100)");
 					sep = ",";
 					printed = 1;
 				}

--EVF5PPMfhYS0aIcm--