Subject: Re: uvm_km_valloc_align() and USPACE (Re: CVS commit: syssrc)
To: None <thorpej@zembu.com>
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
List: tech-kern
Date: 12/01/2000 04:16:03
In <20001130104202.A1350@dr-evil.z.zembu.com>
thorpej@zembu.com wrote:
> On Fri, Dec 01, 2000 at 03:34:36AM +0900, Izumi Tsutsui wrote:
>
> > > s/NBPG/PAGE_SIZE/ please.
> >
> > Currently, USPACE on all ports (except sparc/sparc64) defined
> > as (UPAGES * NBPG). Should these be fixed, too?
>
> If it's in machdep code, NBPG is "okay". But we should be purging NBPG
> from MI code -- we already have PAGE_SIZE, which properly deals with
> different page sizes on systems that have that issue (e.g. SPARC).
I see, but it seems sparc/include/param.h defines NBPG properly.
Just curious, what issue is expected?
> > I guess USPACE_ALIGN is cpu specific, but we don't have
> > powerpc/include/vmparam.h nor m68k/include/vmparam.h.
> > Are these files needed?
>
> I think so, and we should move as many of the common constants into those
> files as possible.
Ok, I'll handle m68k case.
BTW, how about MAXSLP? All ports have the same value for it. (kern/9423)
---
Izumi Tsutsui
tsutsui@ceres.dti.ne.jp