Subject: Re: uvm_mmap.c 1.47
To: Jason R Thorpe <thorpej@zembu.com>
From: Todd Vierling <tv@wasabisystems.com>
List: tech-kern
Date: 01/07/2001 15:14:48
On Sun, 7 Jan 2001, Jason R Thorpe wrote:
: > I believe this change is VERY, VERY WRONG, as it specifically breaks
: > valid usage of mprotect(2). I wouldn't be at all surprised to find
: > out that it actually breaks some software that does dynamic code
: > compilation.
:
: Also, you should take a look at the actual change (I'm not sure that
: you actually did!). It's a one-liner, in the ((flags & MAP_ANON) == 0)
: case of sys_mmap(). Anonymous mappings still get VM_PROT_ALL as the
: maxprot. I should have been more clear about this in my commit message.
Perhaps the syscall should be versioned?
--
-- Todd Vierling <tv@wasabisystems.com> * Wasabi NetBSD: Run with it.
-- NetBSD 1.5 now available on CD-ROM -- http://www.wasabisystems.com/