Subject: Re: vop_symlink and unused vpp?
To: None <tech-kern@netbsd.org>
From: Konrad Schroder <perseant@hitl.washington.edu>
List: tech-kern
Date: 07/16/2001 13:39:50
(oops, forgot to include tech-kern....)

> VOP_SYMLINK takes an argument `struct vnode **vpp' that is never used
> by any of the callers.  It would be hard to use it too, since it's not
[...]
>Appended is a patch for removing it.  Any comments?

LFS uses it; if it didn't exist, lfs_symlink would have to inline
ufs_symlink in order to know whether the symlink succeeded or not, so it
could know whether it had to take VDIROP off of a vnode or not.

------------------------------------------------------------------------
Konrad Schroder          http://www.hitl.washington.edu/people/perseant/
Information Tech & Services   Box 352142 -or- 215 Fluke Hall, Mason Road
Human Interface Technology Lab                  University of Washington
Voice: 206.616.1478   FAX: 206.543.5380          Seattle, WA, 98195, USA