Subject: Re: Another NEW_PIPE bug
To: Charles M. Hannum <abuse@spamalicious.com>
From: Jaromír <jdolecek@netbsd.org>
List: tech-kern
Date: 10/08/2001 22:25:30
Charles M. Hannum wrote:
> returns true in this case, because there are in fact more than
> PIPE_BUF bytes available. However, in pipe_write() we have:
>
> if (space > 0 && (wpipe->pipe_buffer.cnt < PIPE_SIZE)) {
>
> which returns false, because there are more than PIPE_SIZE bytes
> already in the buffer.
> ...
> So, what's the deal here?
Yes, the code in there is clearly wrong. Thanks for finding & fixing it.
Jaromir
--
Jaromir Dolecek <jdolecek@NetBSD.org> http://www.ics.muni.cz/~dolecek/
NetBSD - just plain best OS! -=*=- Got spare MCA cards or docs? Hand me them!