On Tue, Jul 02, 2002 at 01:52:24PM +0200, Matthias Drochner wrote:
> > Anyway, how about this one for merging the stuff in vga_pci.c and
> > pci_quirks.c together:
> > [...]
> 
> I don't think this is a great idea, for a couple of reasons:
> -The needed "quirk" flags are not PCI local - other VGA driver
>  frontends might need them too. Leads to ugly namespace mixing.
> -There is a number of drivers in dev/pci which look up a local
>  database for chip specifics, why special-case VGA?
> -We might find that many or most of ATI cards are broken. In this
>  case it would be a waste to match against each known product ID.

I think just

	if (PCI_VENDOR(vga_pci_quirks[i].id) == PCI_VENDOR_ATI)
		return (vga_pci_quirks[i].quirks);

would be enough, since no ISA ATI cards have been found to be 
broken so far.

Jun-Young

-- 
Bang Jun-Young <junyoung@mogua.com>