it'd be nice if

  (flags & AMAP_EXTEND_NOWAIT) ?  M_NOWAIT : (M_WAITOK | M_CANFAIL)

and was only evaluated once.

also, it's probably better to use UVM_KMF_* flags instead of PR_*
flags for uvm_mapent_alloc().  otherwise it looks good.

-Chuck


On Tue, Nov 26, 2002 at 10:52:42PM +0100, Manuel Bouyer wrote:
> On Thu, Nov 21, 2002 at 01:53:48PM -0500, Andrew Brown wrote:
> > [...]
> > >> otoh, perhaps you mean like this (rather contrived) call path:
> > >
> > >No, I'm just looking at it from an interface point of view.
> > 
> > understood.  all i'm trying to do here is talk you out of expending
> > the effort of reworking the amap_extend() interface.  actually, if you
> > were to do that, i'd suggest that instead of adding a new argument,
> > you should alter the "forwards" argument (of which only one bit is
> > used) to be the flags argument, and put your WAIT/NOWAIT bits in
> > there.
> 
> OK, so what about the attached change ?
> 
> -- 
> Manuel Bouyer <bouyer@antioche.eu.org>
>      NetBSD: 23 ans d'experience feront toujours la difference
> --