On Sat, Aug 16, 2003 at 02:59:25AM +0900, Takayoshi Kochi wrote:
> Hi,
> 
> It seems that no one is actively looking at this PR...
> 
> I updated the proposed patch in PR/21531 to -current and tested
> on my laptop (ThinkPad X31), which worked fine.
> 
> Can someone familiar with ATA (Manuel or Jason?) look at the
> patch and commit if it's ok?

I think you should always do wd_flushcache() before the wd_pm_command().
I've heard that some (probably buggy) drives don't flush the cache on a
standby or sleep command. flushing the cache before shutting down the
drive can't hurt even for non-buggy drives.

Also, why WDCC_STANDBY_IMMED and not WDCC_SLEEP ?

-- 
Manuel Bouyer <bouyer@antioche.eu.org>
     NetBSD: 24 ans d'experience feront toujours la difference
--