Hi,

Could anyone shed light on why there are VM_CMD() and VM_CMD2() macros
defined separately in sys/exec.h? VM_CMD() is just a VM_CMD2() with
the last argument hardcoded 0 and doesn't seem to be very useful.

IMHO, it would be a bit easier to read sources if these were cleaned up
as follows:

Index: exec.h
===================================================================
RCS file: /cvsroot/src/sys/sys/exec.h,v
retrieving revision 1.100
diff -u -r1.100 exec.h
--- exec.h	2003/08/08 18:54:16	1.100
+++ exec.h	2003/08/22 01:40:19
@@ -251,14 +251,10 @@
 void	new_vmcmd __P((struct exec_vmcmd_set *,
 		    int (*) __P((struct proc *, struct exec_vmcmd *)),
 		    u_long, u_long, struct vnode *, u_long, u_int, int));
-#define	NEW_VMCMD(evsp,proc,len,addr,vp,offset,prot) \
-	new_vmcmd(evsp,proc,len,addr,vp,offset,prot,0)
-#define	NEW_VMCMD2(evsp,proc,len,addr,vp,offset,prot,flags) \
+#define	NEW_VMCMD(evsp,proc,len,addr,vp,offset,prot,flags) \
 	new_vmcmd(evsp,proc,len,addr,vp,offset,prot,flags)
 #else	/* DEBUG */
-#define	NEW_VMCMD(evsp,proc,len,addr,vp,offset,prot) \
-	NEW_VMCMD2(evsp,proc,len,addr,vp,offset,prot,0)
-#define	NEW_VMCMD2(evsp,proc,len,addr,vp,offset,prot,flags) do { \
+#define	NEW_VMCMD(evsp,proc,len,addr,vp,offset,prot,flags) do { \
 	struct exec_vmcmd *vcp; \
 	if ((evsp)->evs_used >= (evsp)->evs_cnt) \
 		vmcmdset_extend(evsp); \

Note that I haven't started dealing with the relevant part in the C
sources yet. ;-) 

What do you think?

Jun-Young

-- 
Bang Jun-Young <junyoung@NetBSD.org>