Subject: Re: ffs compat problem since ffs2
To: David Laight <david@l8s.co.uk>
From: Manuel Bouyer <bouyer@antioche.eu.org>
List: tech-kern
Date: 09/26/2003 20:24:12
On Fri, Sep 26, 2003 at 08:17:09AM +0100, David Laight wrote:
> > 
> > I think this code is broken. It will always fail on a pre-ufs2 filesystem.
> > The  !printold in
> > 	if (!printold && afs.fs_old_postblformat != FS_42POSTBLFMT) {
> > should not be there. 
> 
> before rev 1.36 that was:
> 	if (printold && afs.fs_old_postblformat != FS_42POSTBLFMT) {
> and all new filesystems were reported as 'type 0'.
> I inverted the flag because it seemed better that way.
> 
> Maybe I got confused about the number of types of 'old' that are lurking.

The same numer as "new". But the code in this if {} block was here before UFS2,
so it's appropriate for the printold case.
Either there is missing code for the !printold case, or the same code can
be used for both (I think the second)

-- 
Manuel Bouyer <bouyer@antioche.eu.org>
     NetBSD: 23 ans d'experience feront toujours la difference
--