On Mon, Apr 19, 2004 at 07:53:58AM +0000, Jaromir Dolecek wrote:
> 
> Module Name:	src
> Committed By:	jdolecek
> Date:		Mon Apr 19 07:53:58 UTC 2004
> 
> Modified Files:
> 	src/sys/fs/msdosfs: msdosfsmount.h
> 
> Log Message:
> properly version the msdosfs mount structure after addition
> of gmt time offset support (Hi Itojun!); adresses most important
> part of PR kern/25226 by Todd Whitesel
> 
> 
> To generate a diff of this commit:
> cvs rdiff -r1.5 -r1.6 src/sys/fs/msdosfs/msdosfsmount.h
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 

Since there's been _no_ discussion or debate on this, I was planning to
commit the patch later this week (mainly to get the obligatory flaming
over with), but then I updated -current today and got a conflict from this.

Does anyone object to the full patch?
Does anyone feel that mount(2) should be revved to include a struct length?
(I don't know how to go about that and would need guidance.)

Since Jaromir has unilaterally initiated the flag day that gets us back to
compatibility with mount_msdos binaries built before Itojun's gmtoff change,
I'd like to get a long-term fix agreed on and into -2-0 soon, so we don't
end up revisiting this the next couple times msdosfs adds tunable settings.

Also, it occurs to me that the msdos struct probably needs to be added to
the mount(2) man page. I think I can sort that out, but it's only worth
doing after we agree on the versioning.


If no one objects to the full patch by friday (april 23), I'd like to move
forward with everything as proposed in the PR.

Todd Whitesel
toddpw @ netbsd.org