In message <20040521205912.GA1778@antioche.eu.org>, Manuel Bouyer writes:
>On Fri, May 21, 2004 at 04:55:17PM -0400, Steven M. Bellovin wrote:
>> >
>> >Would be a good test. But this flush cache command should be enouth.
>> >Maybe adding a printf here to make sure it's called on last close would
>> >be usefull too.
>> 
>> Demonstrably, it isn't -- as I said, I'm not getting writes flushed 
>> properly when the drive is closed immediately afterwards.
>
>Of maybe the function is called, but the command is a NOP on this drive ...

Could very well be.  And of course, my tests tonight will be different, 
since the drive I had been talking to is now installed in the machine, 
so all I can test on is the old drive...
>
>> >
>> >Also please update to wd.c 1.276, I just added support for DIOCCACHESYNC.
>> >Then you can try dkctl wdX synccache, and see if it complete without errors
>.
>> >
>> That's on -current?
>
>Yes.
>
>> This machine is 2.0beta.  If there are no other 
>> changes, I could try to merge yours and mine, and run that driver on 
>> 2.0.
>
>The changes are small , the diff should apply almost cleanly.
>

Tnx.


		--Steve Bellovin, http://www.research.att.com/~smb