On Mon, Oct 25, 2004 at 05:27:11PM -0700, Bill Studenmund wrote:
> On Mon, Oct 25, 2004 at 12:01:14PM +0200, Peter Postma wrote:
> > I'm working on cleaning up the LKM code, here's my first diff for review:
> > changes the static array to a linked list. I've been running with this diff
> > for a while now and had no problems with LKM's so far.
> > 
> > Most of the code comes from OpenBSD and there's probably room for
> > improvement..
> 
> I'd like to see the change split up. You're muddling real feature changes 
> (getting rid of the static max) with style cleanups. Please don't. It 
> makes figuring out later why things changed much harder. Some of us 
> actually do use cvs annotate to figure out where changes came from. :-)
> 
> Other than that, the only other thing I think you should do is address the 
> used/refcnt question. I'm not 100% sure what the best thing to do is. 
> While I think refcounting would be good, the question is how are the 
> references added & deleted. If an LKM can say, "I depend on this LKM," 
> then they make a lot of sense. Otherwise, it's probably better to leave it 
> as a used flag for now.
> 

I've already committed it, sorry.

I'll change the 'refcnt' back to 'used', then it should be ok..

-- 
Peter Postma