Subject: Re: COPYIN/COPYOUT macro problems Re: IOCTL implementation and kernel/userland addresses
To: Jason Thorpe <thorpej@shagadelic.org>
From: Reinoud Zandijk <reinoud@netbsd.org>
List: tech-kern
Date: 08/25/2005 21:14:32
--rz+pwK2yUstbofK6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Thu, Aug 25, 2005 at 11:44:19AM -0700, Jason Thorpe wrote:
> >- don't discard return values.
> >- why memcpy rather than kcopy?
> >- is there any benefits to use macros? why not functions?
>
> Exactly, this should be implemented as ioctl_copyin() and
> ioctl_copyout() functions that redirect to the appropriate other
> functions. Macros like this are EVIL.
I stand corrected; see my new message for a more generic way.
> >- do you have any plan for non-vnode ioctls?
see my new message :)
Cheers,
Reinoud
--rz+pwK2yUstbofK6
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)
iQEVAwUBQw4YkIKcNwBDyKpoAQLOQAgAvOJhBS4CfA8PLp3JQqAtABNwVDgCcxU7
+gjGn3gqeWFe47nu+1KOTQyC2Or7xd37UV+W3Rk+SiQdHsjsmMxocEYMjY08MZxj
p+aiW0FEhNjWbJvDxVqZTsyrYmTE4MQzZ3uYC5KM5JAAEeJcf6LJcZ/n7M6Jw0Ze
1+97I3l/RLpD9V1iRBh/yB9MenPtQm7O5dLfRBcBDYZRoDSqlID6UGT0nlHshTD2
4GHGzhyD03dtxmZCSHe4jDcWXBNbQxIkvHc8/IBnn3xiZviE7gusKK2G/JCycHmx
LU7oq4N17TzC5xKRCuEtTeKr9S4FCZqltjft0nTvEa/YNhfMwRMDGg==
=h/s+
-----END PGP SIGNATURE-----
--rz+pwK2yUstbofK6--