Subject: dev/sbus/be.c: typo bug?
To: None <tech-kern@netbsd.org>
From: der Mouse <mouse@Rodents.Montreal.QC.CA>
List: tech-kern
Date: 11/04/2005 01:59:26
I went looking at -current's source to see which ethernet drivers
supported which ethercap bits. Grepping for ETHERCAP in dev/sbus
turned up only one hit, be.c. But one line looked odd:
len > ETHER_MAX_LEN + ETHERCAP_VLAN_MTU) {
Looking at the context, I find
if (len <= sizeof(struct ether_header) ||
len > ETHER_MAX_LEN + ETHERCAP_VLAN_MTU) {
#ifdef BEDEBUG
...
#endif
ifp->if_ierrors++;
return;
}
This doesn't look right to me. Surely it should be
ETHER_VLAN_ENCAP_LEN, not ETHERCAP_VLAN_MTU?
/~\ The ASCII der Mouse
\ / Ribbon Campaign
X Against HTML mouse@rodents.montreal.qc.ca
/ \ Email! 7D C8 61 52 5D E7 2D 39 4E F1 31 3E E8 B3 27 4B