--PNpeiK4tTqhYOExY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 27, 2006 at 09:25:57PM -0800, Garrett D'Amore wrote:
> Jason Thorpe wrote:
> >
> > On Feb 27, 2006, at 7:50 PM, Garrett D'Amore wrote:
> >
> What I don't know yet is whether folks feel that this function is
> generally useful enough to include in the PCI framework or not.  I
> suppose I could wrap it in #ifdef's.   The routine probably adds a
> kilobyte or so to a typical image.  It is 1048 bytes in my MIPS32 code,
> and there are a few checks against the class code registers that aren't
> in it, that I would add in a "generic" version.  But I wouldn't have to
> dereference a few fields, because they are passed in directly.  So it is
> probably a net wash around 1 kilobyte.
>=20
> So, is the API useful as is to anyone else?  Or likely enough to be so
> that it should be part of the PCI framework?

My thought is to add it. But if you want to ifdef it, that's fine too. It=
=20
should, however then:

1) be auto-enabled by drivers that need it, and

2) either turned into an LKM or always enabled if LKM support code is=20
compiled in. :-)

Take care,

Bill

--PNpeiK4tTqhYOExY
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)

iD8DBQFEA+W6Wz+3JHUci9cRAj/XAJ0UPof71j7HxGL+Pkrnp3FtPreq6ACeMG9U
v5nSbyMHYR1/7KH1FOQ2UpY=
=WAOW
-----END PGP SIGNATURE-----

--PNpeiK4tTqhYOExY--