Subject: Re: [PATCH] new option BEEP_ONHALT_FOREVER
To: =?ISO-8859-1?Q?M=E1ty=E1s_J=E1nos?= <jani@xoftware.de>
From: Julio M. Merino Vidal <jmmv84@gmail.com>
List: tech-kern
Date: 05/20/2006 23:54:29
On 5/20/06, M=E1ty=E1s J=E1nos <jani@xoftware.de> wrote:
> On Sat, 20 May 2006 19:57:13 +0200
> Quentin Garnier <cube@cubidou.net> wrote:
>
> > I'd rather see this implemented as BEEP_ONHALT_COUNT =3D=3D -1 (or mayb=
e
> > 0) than adding yet another option on the subject. It will make the
> > patch (and documentation) much simpler and clearer.
>
> Hi,
>
> I think you are right. Here comes the simplified version.
I think it'd be better if the check against -1 was done at run time
rather than during build time. Ideally, this functionality could be
configured through sysctl (I wanted to do it, but haven't had the time
yet) and, in that situation, it needs to be checked at run time to
work properly.
Also, when patching manual pages, each sentence should begin in its
own line. And for changes like this, you should bump the date stored
in it.
Cheers,
--=20
Julio M. Merino Vidal <jmmv84@gmail.com>
The Julipedia - http://julipedia.blogspot.com/