Subject: Re: __STDC__ in cdefs_elf.h
To: Garrett D'Amore <garrett_damore@tadpole.com>
From: Jason Thorpe <thorpej@shagadelic.org>
List: tech-kern
Date: 09/08/2006 09:57:22
On Sep 8, 2006, at 9:38 AM, Garrett D'Amore wrote:
> There are a number of tests for __STDC__ in cdefs_elf.h. I think this
> is silly, and makes the code harder to read. Additionally, the link
> set
> support in the file does ANSI token concatenation, but lacks the
> __STDC__ checks.
>
> I'd like to unidef that, removing all the support for pre-ANSI
> environments. About the only conceivable objection I can imagine is
> if
> someone is still using K&R C to build kernels, or if this file is
> somehow used in bootstrapping tools (e.g. to bootstrap GCC from a
> K&R C
> environment).
No one is using K&R C for building kernels anymore, because we are
using ISO C constructs in the kernel.
I don't think anyone for userland is really using gcc -traditional
anymore, either... so I think it's probably fine to remove the
__STDC__ checks and assume it always.
>
> I don't think _either_ is the case (I think even the pdp10 external
> pcc
> compiler supports ANSI C now, although I don't know if those kernels
> are
> built with ELF or not), so I'd like to clean this up.
>
> Objections?
>
> --
> Garrett D'Amore, Principal Software Engineer
> Tadpole Computer / Computing Technologies Division,
> General Dynamics C4 Systems
> http://www.tadpolecomputer.com/
> Phone: 951 325-2134 Fax: 951 325-2191
-- thorpej