Subject: fallout from 'caddr_t' => 'void *' change
To: None <tech-kern@netbsd.org>
From: David Laight <david@l8s.co.uk>
List: tech-kern
Date: 03/08/2007 17:05:50
I've realised that there is a non-obvious piece of fallout from the
recent 'caddr_t' => 'void *' mass edit.
'volative caddr_t ptr' is a volatile pointer to characters (ie the pointer
is likely to be changed).
'volatile void *ptr' is a pointer to volatile data.
The former should have been changed to 'void *volatile ptr'.
A quick grep of an old sauce tree shows the following files to match
grep -rln 'volatile[ \t]*caddr_t' src/sys
./arch/amiga/dev/grf_cl.c
./arch/amiga/dev/grf_cv.c
./arch/amiga/dev/grf_cv3d.c
./arch/amiga/dev/grf_cv3dreg.h
./arch/amiga/dev/grf_cvreg.h
./arch/amiga/dev/grf_et.c
./arch/amiga/dev/grf_rh.c
./arch/amiga/dev/grf_rt.c
./arch/amiga/dev/grfvar.h
./arch/amiga/dev/gvpio.c
./arch/amiga/dev/ite_cv.c
./arch/amiga/dev/ite_cv3d.c
./arch/amiga/dev/ite_rt.c
./arch/atari/vme/et4000.c
./arch/atari/dev/grfabs_et.c
./arch/evbppc/explora/dev/le_elb.c
./arch/hp700/include/iomod.h
./arch/next68k/stand/boot/scsi.c
./arch/pmax/ibus/if_le_ibus.c
./arch/vax/if/if_le.c
./dev/tc/if_le_ioasic.c
./dev/ic/hme.c
./dev/ic/lance.c
Howver some of them seem to be local variables which just doesn't make sense.
David
--
David Laight: david@l8s.co.uk