Subject: Re: USB stack needs early review (Re: Someone should fix our USB stack...)
To: ITOH Yasufumi <itohy@netbsd.org>
From: Tetsuya Isaki <isaki@NetBSD.org>
List: tech-kern
Date: 03/31/2007 16:36:09
ITOH-san,
At Wed, 28 Mar 2007 23:07:27 +0900,
ITOH Yasufumi wrote:
> Here's today's version waiting for review.
:
> ftp://ftp.netbsd.org/pub/NetBSD/misc/itohy/usbtest-20070328.tar.gz
:
> slhci
> - allocate xfer and slhci_xfer at once, and simplify relevant code
> - add slhci_detach()
> - remove second arg of slhci_attach() since it is the same as the first arg.
> - NOT TESTED, missing hardware
Could you separate sl811hs.c into two parts?
1) a lot of your improvement including import from FreeBSD,
like sl11_detach(), memory allocation, etc...
2) synchronization with logic of FreeBSD, like sl11_speed(),
sl11_reset(), (and also sl11read()/sl11write()??)
At least, "#if 1"-ed part in sl11_speed(), sl11_reset() does
not work at my SL811HS/T on x68k. I'm not sure, but it is
caused by difference of chip revision.
(I didn't test with the entire patch of you, sorry...)
---
Tetsuya Isaki <isaki@par.odn.ne.jp / isaki@NetBSD.org>