Subject: Re: Latest bootprops patch (4)
To: Jachym Holecek <freza@NetBSD.org>
From: Juan RP <juan@xtrarom.org>
List: tech-kern
Date: 06/21/2007 13:47:09
On Thu, 21 Jun 2007 13:42:49 +0200
Jachym Holecek <freza@NetBSD.org> wrote:
> # Jared D. McNeill 2007-06-21:
> > New in this patch, the ability to select PCI_*_FIXUP options at
> > runtime. The default values are determined by whether or not the
> > option is present in the kernel, so in the event that persistent
> > bootprops are not used, the kernel will fall back to traditional
> > behavior.
> >
> > http://www.invisible.ca/~jmcneill/netbsd/bootprops4.patch
>
> Maybe you can use functions from prop_dictionary_util.c instead of
> introducing bootprops_get_*?
Yes, at least bootprops_get_bool(), bootprops_get_number() and
bootprops_get_string() can be simplified with prop_dictionary_get_
{bool,*int*,string}.
Also, can you please add a description for the sysctl kern.bootprops?
so that sysctl -d kern.bootprops shows something useful.
--
Juan Romero Pardines - The NetBSD Project
http://plog.xtrarom.org - NetBSD/pkgsrc news in Spanish