This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--0-85717757-1193259065=:21788
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII
Content-ID: <Pine.NEB.4.64.0710251325331.360@localhost.>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

This didn't get any response on tech-userlevel so I repost here.

I would like to change the sensor names for acpi devices.

Currently, the ACPI sensor name includes the name of the device, but its
redundant because the envstat/sysmon/envsys (?) interface requires you to
know that separately in any case.

so
	device "acpiacad0" sensor "acpiacad0 connected" value "ON"

becomes
	device "acpiacad0" sensor "connected" value "ON"

sensors attached to other devices do not contain the device name, so this
would bring the ACPI sensors into line with the convention.

patch to do this is attached.

For compatibility, the API is changed in any case so users of the new API
will deal with the new names. I can additionally modify the GTREINFO ioctl
handler as follows:

- --- /usr/src/sys/dev/sysmon/sysmon_envsys.c	2007-10-24 20:19:10.000000000 +0100
+++ sysmon_envsys.c	2007-10-24 21:48:13.000000000 +0100
@@ -430,8 +430,17 @@

 		if (binfo->sensor < sme->sme_nsensors) {
 			binfo->units = edata->units;
- -			(void)strlcpy(binfo->desc, edata->desc,
- -			    sizeof(binfo->desc));
+
+			/*
+			 * previously, the ACPI sensor names included the
+			 * device name. Include that in compatibility code.
+			 */
+			if (strncmp(sme->sme_name, "acpi", 4) == 0)
+				(void)snprintf(binfo->desc, sizeof(binfo->desc),
+				    "%s %s", sme->sme_name, edata->desc);
+			else
+				(void)strlcpy(binfo->desc, edata->desc,
+				    sizeof(binfo->desc));
 		}

 		DPRINTFOBJ(("%s: binfo->units=%d binfo->validflags=%d\n",

to allow callers to the old API to get the same results.

any comments and/or objections?

iain
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (NetBSD)

iQEVAwUBRyCRLfFJxoMWDXVDAQL8Agf+PH1LGRQtTubPByS9XphOMT4xz1fjBN8f
iMKPvrLh4TtSWjO18bQc6i8NkWNHO0ZXAMOx4lbGsauWEluZMjIaX8NmwnChkyJl
TY6CPht3b1HCSbtOkqcSen2EjS6Wc0NxvYbifigQhIyEY26FHaqfHHRkkF/3tIMS
UAJg5pyQjH+l6oYiPuVu32XQQbW4Mf8auHQWGUmuGIxoYhrr2o7iP0jsFb6TmteP
PgC8avISMs6CktJxqpzcQDsbI7yLq8mRC2KHTzVQjez15xwFJPwuv1RFqUbNdX54
xg3ICucpHbdcNDkh9iiXGz8D28e8wcAkmOQeCSUbMyA7EtxEPDxynQ==
=D5+U
-----END PGP SIGNATURE-----
--0-85717757-1193259065=:21788
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME=acpi.diff
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.NEB.4.64.0710242151050.21788@localhost.>
Content-Description: remove ACPI device names from sensor name
Content-Disposition: ATTACHMENT; FILENAME=acpi.diff

LS0tIC91c3Ivc3JjL3N5cy9kZXYvYWNwaS9hY3BpX2FjYWQuYwkyMDA3LTEw
LTI0IDIwOjE3OjQ0LjAwMDAwMDAwMCArMDEwMA0KKysrIHNyYy9zeXMvZGV2
L2FjcGkvYWNwaV9hY2FkLmMJMjAwNy0xMC0yNCAyMTowMjo0My4wMDAwMDAw
MDAgKzAxMDANCkBAIC0yNzUsOCArMjc1LDcgQEANCiAJc2MtPnNjX2RhdGFb
MF0uc2Vuc29yID0gMDsNCiAJc2MtPnNjX2RhdGFbMF0uc3RhdGUgPSBFTlZT
WVNfU1ZBTElEOw0KIAlzYy0+c2NfZGF0YVswXS51bml0cyA9IEVOVlNZU19J
TkRJQ0FUT1I7DQotCXNucHJpbnRmKHNjLT5zY19kYXRhWzBdLmRlc2MsIHNp
emVvZihzYy0+c2NfZGF0YS0+ZGVzYyksDQotCSAgICAiJXMgJXMiLCBkZXZp
Y2VfeG5hbWUoZHYpLCAiY29ubmVjdGVkIik7DQorIAlzdHJsY3B5KHNjLT5z
Y19kYXRhWzBdLmRlc2MsICJjb25uZWN0ZWQiLCBzaXplb2Yoc2MtPnNjX2Rh
dGFbMF0uZGVzYykpOw0KIA0KIAlzYy0+c2Nfc3lzbW9uLnNtZV9zZW5zb3Jf
ZGF0YSA9IHNjLT5zY19kYXRhOw0KIAlzYy0+c2Nfc3lzbW9uLnNtZV9uYW1l
ID0gZGV2aWNlX3huYW1lKGR2KTsNCi0tLSAvdXNyL3NyYy9zeXMvZGV2L2Fj
cGkvYWNwaV9hcG0uYwkyMDA3LTA3LTIwIDIyOjIwOjUzLjAwMDAwMDAwMCAr
MDEwMA0KKysrIHNyYy9zeXMvZGV2L2FjcGkvYWNwaV9hcG0uYwkyMDA3LTEw
LTI0IDIwOjU5OjI4LjAwMDAwMDAwMCArMDEwMA0KQEAgLTMxOCwzMSArMzE4
LDMxIEBADQogCQlEUFJJTlRGKCgiJWQgJXMgJWQgJWRcbiIsIGksIGRlc2Ms
IGRhdGEsIGZsYWdzKSk7DQogCQlpZiAoKGZsYWdzICYgRU5WU1lTX0ZDVVJW
QUxJRCkgPT0gMCkNCiAJCQljb250aW51ZTsNCi0JCWlmIChzdHJzdHIoZGVz
YywgIiBjb25uZWN0ZWQiKSkgew0KKwkJaWYgKHN0cmNtcChkZXNjLCAiY29u
bmVjdGVkIikgPT0gMCkgew0KIAkJCXBpbmZvLT5hY19zdGF0ZSA9IGRhdGEg
PyBBUE1fQUNfT04gOiBBUE1fQUNfT0ZGOw0KLQkJfSBlbHNlIGlmIChzdHJz
dHIoZGVzYywgIiBwcmVzZW50IikgJiYgZGF0YSA9PSAwKQ0KKwkJfSBlbHNl
IGlmIChzdHJjbXAoZGVzYywgInByZXNlbnQiKSA9PSAwICYmIGRhdGEgPT0g
MCkNCiAJCQlwaW5mby0+YmF0dGVyeV9mbGFncyB8PSBBUE1fQkFUVF9GTEFH
X05PX1NZU1RFTV9CQVRURVJZOw0KLQkJZWxzZSBpZiAoc3Ryc3RyKGRlc2Ms
ICIgY2hhcmdpbmciKSAmJiBkYXRhKQ0KKwkJZWxzZSBpZiAoc3RyY21wKGRl
c2MsICJjaGFyZ2luZyIpID09IDAgJiYgZGF0YSkNCiAJCQlwaW5mby0+YmF0
dGVyeV9mbGFncyB8PSBBUE1fQkFUVF9GTEFHX0NIQVJHSU5HOw0KLQkJZWxz
ZSBpZiAoc3Ryc3RyKGRlc2MsICIgY2hhcmdpbmciKSAmJiAhZGF0YSkNCisJ
CWVsc2UgaWYgKHN0cmNtcChkZXNjLCAiY2hhcmdpbmciKSA9PSAwICYmICFk
YXRhKQ0KIAkJCXBpbmZvLT5iYXR0ZXJ5X2ZsYWdzICY9IH5BUE1fQkFUVF9G
TEFHX0NIQVJHSU5HOw0KLQkJZWxzZSBpZiAoc3Ryc3RyKGRlc2MsICIgd2Fy
biBjYXAiKSkNCisJCWVsc2UgaWYgKHN0cmNtcChkZXNjLCAid2FybiBjYXAi
KSA9PSAwKQ0KIAkJCXdhcm5jYXAgPSBkYXRhIC8gMTAwMDsNCi0JCWVsc2Ug
aWYgKHN0cnN0cihkZXNjLCAiIGxvdyBjYXAiKSkNCisJCWVsc2UgaWYgKHN0
cmNtcChkZXNjLCAibG93IGNhcCIpID09IDApDQogCQkJbG93Y2FwID0gZGF0
YSAvIDEwMDA7DQotCQllbHNlIGlmIChzdHJzdHIoZGVzYywgIiBsYXN0IGZ1
bGwgY2FwIikpIHsNCisJCWVsc2UgaWYgKHN0cmNtcChkZXNjLCAibGFzdCBm
dWxsIGNhcCIpID09IDApIHsNCiAJCQlsYXN0Y2FwICs9IGRhdGEgLyAxMDAw
Ow0KIAkJCWxhc3RjYXBfdmFsaWQgPSAxOw0KIAkJfQ0KLQkJZWxzZSBpZiAo
c3Ryc3RyKGRlc2MsICIgZGVzaWduIGNhcCIpKQ0KKwkJZWxzZSBpZiAoc3Ry
Y21wKGRlc2MsICJkZXNpZ24gY2FwIikgPT0gMCkNCiAJCQlkZXNjYXAgPSBk
YXRhIC8gMTAwMDsNCi0JCWVsc2UgaWYgKHN0cnN0cihkZXNjLCAiIGNoYXJn
ZSIpICYmDQotCQkgICAgc3Ryc3RyKGRlc2MsICIgY2hhcmdlIHJhdGUiKSA9
PSBOVUxMKSB7DQorCQllbHNlIGlmIChzdHJjbXAoZGVzYywgImNoYXJnZSIp
ID09IDAgJiYNCisJCSAgICBzdHJjbXAoZGVzYywgImNoYXJnZSByYXRlIikp
IHsNCiAJCQljYXAgKz0gZGF0YSAvIDEwMDA7DQogCQkJY2FwX3ZhbGlkID0g
MTsNCiAJCQlwaW5mby0+bmJhdHRlcnkrKzsNCiAJCX0NCi0JCWVsc2UgaWYg
KHN0cnN0cihkZXNjLCAiIGRpc2NoYXJnZSByYXRlIikpIHsNCisJCWVsc2Ug
aWYgKHN0cmNtcChkZXNjLCAiZGlzY2hhcmdlIHJhdGUiKSA9PSAwKSB7DQog
CQkJZGlzY2hhcmdlICs9IGRhdGEgLyAxMDAwOw0KIAkJCWRpc2NoYXJnZV92
YWxpZCA9IDE7DQogCQl9DQotLS0gL3Vzci9zcmMvc3lzL2Rldi9hY3BpL2Fj
cGlfYmF0LmMJMjAwNy0xMC0yNCAyMDoxNzo0NC4wMDAwMDAwMDAgKzAxMDAN
CisrKyBzcmMvc3lzL2Rldi9hY3BpL2FjcGlfYmF0LmMJMjAwNy0xMC0yNCAy
MTowMjo1MS4wMDAwMDAwMDAgKzAxMDANCkBAIC02OTIsOCArNjkyLDggQEAN
CiAJc2MtPnNjX2RhdGFbaW5kZXhdLnNlbnNvciA9IGluZGV4OwkJCQlcDQog
CXNjLT5zY19kYXRhW2luZGV4XS51bml0cyA9IHVuaXQ7ICAgICAJCQkJXA0K
IAlzYy0+c2NfZGF0YVtpbmRleF0uc3RhdGUgPSBFTlZTWVNfU1ZBTElEOwkJ
CVwNCi0Jc25wcmludGYoc2MtPnNjX2RhdGFbaW5kZXhdLmRlc2MsIHNpemVv
ZihzYy0+c2NfZGF0YS0+ZGVzYyksCVwNCi0JICAgICIlcyAlcyIsIGRldmlj
ZV94bmFtZShkdiksIHN0cmluZyk7CQkJCVwNCisgCXN0cmxjcHkoc2MtPnNj
X2RhdGFbaW5kZXhdLmRlc2MsIHN0cmluZywJCQlcDQorIAkgICAgc2l6ZW9m
KHNjLT5zY19kYXRhW2luZGV4XS5kZXNjKSk7DQogDQogCUlOSVREQVRBKEFD
UElCQVRfUFJFU0VOVCwgRU5WU1lTX0lORElDQVRPUiwgInByZXNlbnQiKTsN
CiAJSU5JVERBVEEoQUNQSUJBVF9EQ0FQQUNJVFksIGNhcHVuaXQsICJkZXNp
Z24gY2FwIik7DQotLS0gL3Vzci9zcmMvc3lzL2Rldi9hY3BpL2FjcGlfdHou
YwkyMDA3LTEwLTI0IDIwOjE3OjQ3LjAwMDAwMDAwMCArMDEwMA0KKysrIHNy
Yy9zeXMvZGV2L2FjcGkvYWNwaV90ei5jCTIwMDctMTAtMjQgMjA6NTk6Mjgu
MDAwMDAwMDAwICswMTAwDQpAQCAtNTg5LDggKzU4OSw4IEBADQogCX0NCiAj
ZGVmaW5lIElOSVREQVRBKGluZGV4LCB1bml0LCBzdHJpbmcpIFwNCiAJc2Mt
PnNjX2RhdGFbaW5kZXhdLnVuaXRzID0gdW5pdDsJCQkJICAgXA0KLQlzbnBy
aW50ZihzYy0+c2NfZGF0YVtpbmRleF0uZGVzYywgc2l6ZW9mKHNjLT5zY19k
YXRhW2luZGV4XS5kZXNjKSwgXA0KLQkgICAgIiVzICVzIiwgc2MtPnNjX2Rl
di5kdl94bmFtZSwgc3RyaW5nKTsNCisJc3RybGNweShzYy0+c2NfZGF0YVtp
bmRleF0uZGVzYywgc3RyaW5nLAkJCSAgIFwNCisJICAgIHNpemVvZihzYy0+
c2NfZGF0YVtpbmRleF0uZGVzYykpOw0KIA0KIAlJTklUREFUQShBVFpfU0VO
U09SX1RFTVAsIEVOVlNZU19TVEVNUCwgInRlbXBlcmF0dXJlIik7DQogDQo=

--0-85717757-1193259065=:21788--