tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: broken src/sys/arch/x86/isa/clock.c (i8254_get_timecount)



Hi chuck !

> On Wed, Jan 16, 2008 at 08:52:54AM +0100, Frank Kardel wrote:
>> Hi !
<< [...]
>>I'd go for the second one as it is needed to suppress the ..._offset
>> update
>> from the clock interrupt code. If it would not be there, the wrap would
>> be detected and ..._offset would be incremented in ...get_timecount AND
>> in the clock interrupt code - this would result in a clock running
>> sometimes fast.
>
>
> OK, makes sense.   I did that simple one in HEAD and I'll put in for some
> sort of pullup to netbsd-4.
I interpret that as that you will upgrade to the second solution or Joerg
path then (esp. for the netbsd-4 pullup), right ?
>
> Joerg has sent me a more involved patch that fixes this and cleans it up
> a bit which he may commit later?
>

Fine with me. Joerg has been doing quite a bit of timecounter work
lately. With all that work I hope we are able to retire the old timekeeping
implementation sometime now.

> thanks,
> chuck
>

Frank




Home | Main Index | Thread Index | Old Index