Re: MODULAR: Add support for load-time options

[David Laight <david%l8s.co.uk@localhost>]

On Sat, Feb 09, 2008 at 09:40:22AM +0100, Julio M. Merino Vidal wrote:
> +handle_modctl_load(void *arg)
> +{
> +     modctl_load_t *ml = (modctl_load_t *)arg;
...
> +     char params[4096];
...
> +     error = copyinstr(ml->ml_params, params, sizeof(params), NULL);

An on-stack 4k buffer doesn't seem like an especially bright idea!
It might be better to get the user to pass in the length.

        David

-- 
David Laight: david%l8s.co.uk@localhost