Re: accept_filter, accf_http, setsockopt and the EINVAL error

[Sverre Froyen <sverre%viewmark.com@localhost>]

On Fri June 26 2009 14:24:35 Thor Lancelot Simon wrote:
> On Fri, Jun 26, 2009 at 02:07:04PM -0600, Sverre Froyen wrote:
> > FreeBSD's code is identical.  Despite that fact, I've attached a patch
> > that makes setsockopt silently ignore the second call.  Please note that
> > I do not allow replacing a filter with a different type, only adding the
> > same type twice.
>
> If FreeBSD's code is identical, then Apache is broken, right?  Why
> shouldn't we just patch Apache in pkgsrc and feed the fix back to its
> maintainers?

That would be fine.  My original message had a slightly different angle, 
however.  It was based on the following series of events:

I see the Apache warning in the log and I'm concerned that it means that 
accept filters are not being used.  I then look for EINVAL in the man page for 
setsockopt.  Nothing there, or in any of the accept filter man pages.  I then 
examine that Apache calls.  They all look fine.  Finally, tracing the calls 
reveals the double calls to setsockopt and examining the kernel code shows 
that the warning can be safely ignored.

I was looking for ways to get to that conclusion more easily.  Updating the 
man pages would help.  Changing the kernel code means I would not even have 
looked.

Regards,
Sverre