Re: Quirk WD_QUIRK_SPLIT_MOD15_WRITE

[David Laight <david%l8s.co.uk@localhost>]

On Sat, Dec 05, 2009 at 01:53:21PM +0000, David Laight wrote:
> sys/dev/ata/wd.c has some very strange code for the
> WD_QUIRK_SPLIT_MOD15_WRITE quirk.
> 
> The code splits in two any transfers where the 'sector_count % 15 == 1'.
> It appears to do this by dividing the byte transfer size in two.
> This is fine for 16 sector transfers (converts one 16k byte transfer
> into two 8k transfers), but it next applies to 31 sector transfers and
> I can't help thinking that the requests for 15.5 sectors aren't going
> to be processed correctly!
> 
> Have I missed something?

Apart for the fact that it converts an 8k transfer into two 4k ones ;-)

Perhaps it should just do the first 4k separately.

        David

-- 
David Laight: david%l8s.co.uk@localhost