tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Length of wmesg for condvar?



The condvar(9) man page states "The wmesg argument specifies a string of no more than 8 characters..." yet there is at least one instance in the kernel sources where we have a wmesg long than 8 characters! In src/sys/kern/kern_module.c in routine module_init() we have

        cv_init(&module_thread_cv, "modunload");

There appear to be several other similar violations in various places:

        src/sys/arch/x86/x86/ipmi.c
        src/sys/arch/xen/xen/balloon.c
        src/sys/dev/isa/fd.c
        src/sys/dev/tprof/tprof.c
        src/sys/dist/ipf/netinet/ip_auth.c
        src/sys/dist/ipf/netinet/ip_log.c
        src/sys/dist/ipf/netinet/ip_sync.c
        src/sys/fs/nilfs/nilfs_subr.c
        src/sys/fs/nilfs/nilfs_vfsops.c
        src/sys/kern/sys_pipe.c
        src/sys/net/agr/if_agr.c
        src/sys/opencrypto/crypto.c
        src/sys/rump/librump/rumpkern/sysproxy_socket.c

Should these be changed? Are there any adverse effects from having a wmesg longer than 8 characters?

-------------------------------------------------------------------------
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------


Home | Main Index | Thread Index | Old Index