Re: USB_DEBUG mess

[David Laight <david%l8s.co.uk@localhost>]

On Sat, Jan 05, 2013 at 11:12:29PM +0000, Christos Zoulas wrote:
> In article <C873ACDC-A444-4442-A021-42C621D868AB%3am-software.com@localhost>,
> Matt Thomas  <matt%3am-software.com@localhost> wrote:
> >
> >http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/dev/usb/files.usb?rev=1.106&content-type=text/x-cvsweb-markup
> >> 
> >> Normally, the XXX_DEBUG options are not specified in any files.* files,
> >> meaning that as they are unknown options, they will translate into a
> >> CPPFLAG of -DXXX_DEBUG in the kernel Makefile
> >
> >which is means if you do the define, your sources don't properly get rebuilt.
> >That's why it was made a config option.
> 
> Yes, but now every file that includes usb.h needs to include opt_usb.h before,
> otherwise things don't build right. I'll fix it properly for now until we
> decide something else.

How much of a difference does it make to the structure layouts?
If there are only a few fields the extra space probably doesn't matter.

        David

-- 
David Laight: david%l8s.co.uk@localhost