tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Set of 26 potential bugs



Le 05/08/2014 18:18, Rich Neswold a écrit :
> On Mon, Jul 28, 2014 at 2:44 PM, Maxime Villard <max%m00nbsd.net@localhost 
> <mailto:max%m00nbsd.net@localhost>> wrote:
> 
>     I've improved my code scanner, and it has found 26 potential bugs under 
> sys/.
>     Instead of flooding tech-kern@/tech-net@/etc with questions and fixes, I 
> put
>     here a comprehensive list:
> 
>             http://m00nbsd.net/ae123a9bae03f7dde5c6d654412daf5a.html#Report-2
> 
> 
> Is (#02-0x03) really a problem? The code looks correct to me.
> 
> Near the end of this same file, however, I see:
> 
>     rl->cprl_count++;
> 
> followed a few lines later by:
> 
>     if (rl == NULL) {
>         sc->error = ENOMEM;
>         return;
>     }                                       
> 
> which looks like a problem.
> 
> -- 
> Rich

Hum hum, you're right. After debugging a bit, it seems that it took the wrong
line, and indeed l.363 is the problem.



Home | Main Index | Thread Index | Old Index