Re: [PATCH] fallocate() for FFS

[manu%netbsd.org@localhost (Emmanuel Dreyfus)]

Emmanuel Dreyfus <manu%netbsd.org@localhost> wrote:

> Implementing fallocate for FFS seems quite obvious.  Is there anything I
> missed in the patch below? Is it good enough to commit?

Updated version that spares some panic by properly calling
uvm_vnp_setsize(). Any comment?

Index: sys/ufs/ffs/ffs_extern.h
===================================================================
RCS file: /cvsroot/src/sys/ufs/ffs/ffs_extern.h,v
retrieving revision 1.80
diff -U 4 -r1.80 ffs_extern.h
--- sys/ufs/ffs/ffs_extern.h    16 Jun 2013 13:33:30 -0000      1.80
+++ sys/ufs/ffs/ffs_extern.h    26 Sep 2014 03:59:05 -0000
@@ -126,8 +126,9 @@
 
 /* ffs_vnops.c */
 int    ffs_read(void *);
 int    ffs_write(void *);
+int    ffs_fallocate(void *);
 int    ffs_fsync(void *);
 int    ffs_spec_fsync(void *);
 int    ffs_reclaim(void *);
 int    ffs_getpages(void *);
Index: sys/ufs/ffs/ffs_vnops.c
===================================================================
RCS file: /cvsroot/src/sys/ufs/ffs/ffs_vnops.c,v
retrieving revision 1.125
diff -U 4 -r1.125 ffs_vnops.c
--- sys/ufs/ffs/ffs_vnops.c     25 Jul 2014 08:20:53 -0000      1.125
+++ sys/ufs/ffs/ffs_vnops.c     26 Sep 2014 03:59:05 -0000
@@ -114,9 +114,9 @@
        { &vop_getattr_desc, ufs_getattr },             /* getattr */
        { &vop_setattr_desc, ufs_setattr },             /* setattr */
        { &vop_read_desc, ffs_read },                   /* read */
        { &vop_write_desc, ffs_write },                 /* write */
-       { &vop_fallocate_desc, genfs_eopnotsupp },      /* fallocate */
+       { &vop_fallocate_desc, ffs_fallocate },         /* fallocate */
        { &vop_fdiscard_desc, genfs_eopnotsupp },       /* fdiscard */
        { &vop_ioctl_desc, ufs_ioctl },                 /* ioctl */
        { &vop_fcntl_desc, ufs_fcntl },                 /* fcntl */
        { &vop_poll_desc, ufs_poll },                   /* poll */
@@ -326,8 +326,43 @@
        return error;
 }
 
 int
+ffs_fallocate(void *v)
+{
+       struct vop_fallocate_args /* {
+               struct vnode *a_vp;
+               off_t a_pos;
+               off_t a_len;
+       } */ *ap = v;
+       struct vnode *vp;
+       struct mount *mp;
+       int error;
+
+
+       vp = ap->a_vp;
+       mp = vp->v_mount;
+
+       fstrans_start(mp, FSTRANS_LAZY);
+       error = UFS_WAPBL_BEGIN(vp->v_mount);
+       if (error)
+               goto out;
+
+       genfs_node_wrlock(vp);
+       error = GOP_ALLOC(vp, ap->a_pos, ap->a_len, 0, curlwp->l_cred);
+       if (!error && ap->a_pos + ap->a_len > vp->v_size)
+               uvm_vnp_setsize(vp, ap->a_pos + ap->a_len);
+       genfs_node_unlock(vp);
+
+       UFS_WAPBL_UPDATE(vp, NULL, NULL, 0);
+       UFS_WAPBL_END(vp->v_mount);
+out:
+       fstrans_done(mp);
+
+       return error;
+}
+
+int
 ffs_fsync(void *v)
 {
        struct vop_fsync_args /* {
                struct vnode *a_vp;

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu%netbsd.org@localhost