Re: Unreleased vnode in linux_sys_uselib()

[Nicolas Joly <njoly%pasteur.fr@localhost>]

On Sat, Oct 18, 2014 at 01:06:21PM +0200, Maxime Villard wrote:
> Hi,
> there seems to be a vnode issue in compat/linux/common/linux_uselib.c:
> 
> 115	if (LINUX_N_MACHTYPE(&hdr) != LINUX_MID_MACHINE)
> 116		return ENOEXEC;
> 
> Here 'vp' is not released. Patch:
[...]
> And I'm wondering: what is the impact of such bugs? njoly@ tested a
> small sample I sent him and apparently there doesn't seem to be any
> glaring issue.

Got it. It prevents unmounting the corresponding filesystem ...

Without the vrele calls the vnode v_usecount value won't be lowered as
expected and kernel will wrongly think it's still in use at umount

I checked that your patch do fix this issue.

-- 
Nicolas Joly

Biology IT Center
Institut Pasteur, Paris.