tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Changing the return value of xxx_attach() from void to int.



On Sat, Jul 09, 2016 at 08:45:15PM -0700, John Nemeth wrote:
 > } The substance of that reservation is that there's not much point doing
 > } it without also taking the time to correct the behavior, i.e., back
 > } out properly if something fails. And that requires attention, not just
 > } mechanical changes.
 > 
 >      Sure, but that's something that can be done over time, driver
 > by driver.  The first step is the infrastructure support (changing
 > the return type, having autoconf respond intelligently, etc.).
 > The very first step of changing the return type is a purely mechanical
 > change.

Well, yes, but if you change the return type mechanically first then
you end up with a thousand or two attach functions that *look* like
they handle errors but actually don't.

-- 
David A. Holland
dholland%netbsd.org@localhost


Home | Main Index | Thread Index | Old Index