Re: _lwp_create change

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Thu, Apr 20, 2017 at 06:48:01AM +0200, Martin Husemann wrote:
> On Thu, Apr 20, 2017 at 02:29:26AM +0200, Joerg Sonnenberger wrote:
> > As discussed previously, I think the patch makes the behavior worse and
> > the Go implementation is kind of stupid as well.
> 
> No comment on the patch of the go implementation, but I think that the
> code should actually do what the documentation says:
> 
> 	The context argument specifies the
>      initial execution context for the new LWP including signal mask, stack,
>      and machine registers.
> 
> Specifying the signal stack in the create call does make sense to me.

Note: stack here means the regular stack. It is not "signal mask, signal
stack, stack, machine registers". Christos wants to overload the stack
field to be polymorphic. I don't mind fixing the signal mask handling,
that's a clear bug. Changing the stack to have a new double meaning is
bad though.

Joerg