tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: RFC: New userspace fetch/store API



> On Feb 23, 2019, at 4:19 PM, Jason Thorpe <thorpej%me.com@localhost> wrote:
>> On Feb 23, 2019, at 4:04 PM, matthew green <mrg%eterna.com.au@localhost> wrote:
>> 
>> i like this.  the current API is ... odd.
>> 
>> can you add alignment documentation?  eg, if only to say that it
>> must support aligned or unaligned accesses for the relevant
>> datatypes.  not sure what we need currently, ie, if unaligned is
>> needed because that happens today, or we can define it as wrong
>> in this API.
> 
> Yah, I’ll make that clear.  It’s implicit in the current API (alpha would blow up otherwise), but I will make it explicit.

I added the following:

<quote>
All addresses MUST be naturally-aligned for their type.  If unaligned
access is required, use copy(9).
</quote>

OK?

-- thorpej



Home | Main Index | Thread Index | Old Index