On Tue, 2019-06-25 at 20:55 +0200, Maxime Villard wrote: > Le 22/06/2019 à 09:38, Michał Górny a écrit : > > Hi, > > > > Attached is the next version of unified patch. I've updated the boolean > > logic as requested, and fixed indentations. > > Looks good to me. Please don't use ()s when not needed, like > > - memset(&(xstate->xs_fxsave), 0, sizeof(xstate->xs_fxsave)); > - process_s87_to_xmm(&fpu_save->sv_87, &(xstate->xs_fxsave)); > + memset(&xstate->xs_fxsave, 0, sizeof(xstate->xs_fxsave)); > + process_s87_to_xmm(&fpu_save->sv_87, &xstate->xs_fxsave); > > but whatever, this is detail Will do. Thanks for the review. Is it fine to commit then? -- Best regards, Michał Górny
Attachment:
signature.asc
Description: This is a digitally signed message part