Re: All (?) network tests failing

[christos%astron.com@localhost (Christos Zoulas)]

In article <19747.1585851026%jinx.noi.kre.to@localhost>,
Robert Elz  <kre%munnari.OZ.AU@localhost> wrote:
>    Date:        Mon, 30 Mar 2020 14:25:01 -0400
>    From:        Christos Zoulas <christos%zoulas.com@localhost>
>    Message-ID:  <3D3AC2B9-5E6E-400C-9A4B-10742C90CE91%zoulas.com@localhost>
>
>  | All the tests are failing for you the same way:
>  | rump.route: SO_RERROR: Socket operation on non-socket
>
>Not all, but quite a few are.
>
>This one I think is due to src/sbin/route/rouyte.c 1.167
>
> 	                 sock = prog_socket(PF_ROUTE, SOCK_RAW, 0);
>  	                 if (setsockopt(sock, SOL_SOCKET, SO_RERROR,
>  	                     &on, sizeof(on)) == -1)
>  	                         warn("SO_RERROR");
>
>where that setcockopt() was added.   I think that needs to be a prog_*
>type call, so rump can do the right thing.   That will mean adding it
>to prog_opts, and right now I don't have time to work out what the correct
>magic is, but if no-one else does in the next day or so, I will take
>another look.
>
>That should take care of the failing network related tests that contain
>rump.route commands, but that's not all of the failing tests.

Thanks! I fixed that now. Let's see how many break after this...

christos