Another option issue [was Re: Rump makes the kernel problematically brittle]

[Mouse <mouse%Rodents-Montreal.ORG@localhost>]

>> Yes, I got a very nice and helpful off-list mail (thank you!)
>> saying, approximately, that I needed to have the #include of
>> opt_autoconf.h inside the _KERNEL_OPT conditional.
> As you guessed, that was the issue I suspected.

Okay, I've now tried something I rarely try - build.sh release - and
have another, related, question.  Admittedly, though, it's for an old
release.

This was for 5.2, and build.sh release on amd64 failed.  It appears to
come from my adding another option file, opt_halted_message.h, in
support of an option to allow a kernel config to provide a replacement
for the "halted, press any key to reboot" message.  This has worked
fine for build.sh build runs.  But this build.sh release run failed

release ===> etc (with: DISTRIBUTION_DONE=1)
[...]
#    create  XEN3_DOM0/machdep.d
CC=/home/mouse/amd64/OBJDIR/tooldir.NetBSD-5.2-amd64/bin/x86_64--netbsd-gcc /home/mouse/amd64/OBJDIR/tooldir.NetBSD-5.2-amd64/bin/nbmkdep -f machdep.d --  -mcmodel=kernel -mno-red-zone -ffreestanding -fno-zero-initialized-in-bss -g -O2 -fno-omit-frame-pointer -std=gnu99 -fno-strict-aliasing   -Werror -Wall -Wno-main -Wno-format-zero-length -Wpointer-arith -Wmissing-prototypes -Wstrict-prototypes -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wno-unreachable-code -Wno-sign-compare -Wno-pointer-sign -Wno-attributes -Wextra -Wno-unused-parameter  -Werror    -Damd64 -Dx86_64 -I. -I/home/mouse/amd64/OBJDIR/sys/arch/amd64/compile/XEN3_DOM0/xen-ma -I/usr/src/sys/../common/include -I/usr/src/sys/arch  -I/usr/src/sys -nostdinc -DMSGBUFSIZE="24576" -DLKM -DDIAGNOSTIC -DDEBUG -DMAXUSERS=32 -D_KERNEL -D_KERNEL_OPT -I/usr/src/sys/lib/libkern/../../../common/lib/libc/quad -I/usr/src/sys/lib/libkern/../../../common/lib/libc/string -I/usr/src/sys/lib/libkern/../../../common/lib/libc/arch/x86_!
64/string   -I/usr/src/sys/external/isc/atheros_hal/dist -I/usr/src/sys/external/isc/atheros_hal/ic -I/usr/src/sys/dist/ipf  /usr/src/sys/arch/amd64/amd64/machdep.c
/usr/src/sys/arch/amd64/amd64/machdep.c:130:32: error: opt_halted_message.h: No such file or directory

I added the #include to a long string of #include "opt_....h" lines,
none of which are conditional on anything, in
sys/arch/amd64/amd64/machdep.c.

Of course, it's entirely possible nobody remembers enough from far
enough back to say anythng useful.  But, if anyone does, I'd appreciate
any pointers to what I might have done wrong or where to look to fix
this.

/~\ The ASCII				  Mouse
\ / Ribbon Campaign
 X  Against HTML		mouse%rodents-montreal.org@localhost
/ \ Email!	     7D C8 61 52 5D E7 2D 39  4E F1 31 3E E8 B3 27 4B