tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: protect pmf from network drivers that don't provide if_stop



Martin Husemann <martin%duskware.de@localhost> writes:

> On Tue, Jun 29, 2021 at 03:46:20PM +0930, Brett Lymn wrote:
>> I turned up a fix I had put into my source tree a while back, I think at
>> the time the wireless driver (urtwn IIRC) did not set an entry for
>> if_stop.
>
> This is a driver bug, we should not work around it but catch it early
> and fix it.

So maybe KASSERT that stop exists, and then call it if non-NULL, so
regular users don't crash, and DIAGNOSTIC does what DIAGNOSTIC is
supposed to do?

Attachment: signature.asc
Description: PGP signature



Home | Main Index | Thread Index | Old Index