Re: DRM/KMS: vmwgfx driver is now available

[Taylor R Campbell <campbell+netbsd-tech-kern%mumble.net@localhost>]

> Date: Sun, 16 Jul 2023 01:12:48 +0900
> From: PHO <pho%cielonegro.org@localhost>
> 
> I've been working on vmwgfx driver, a driver for VMware virtualized GPU. 
> It was partly ported to NetBSD but wasn't buildable, and now it builds 
> and actually works. (Thank you riastradh@, your prior work helped 
> tremendously. I don't think I could do this without it.)
> 
> This is the list of patches I'd like to commit:
> https://github.com/NetBSD/src/compare/trunk...depressed-pho:netbsd-src:drm2-vmwgfx

Amazing!  Cool, I'll take a look.

Some quick questions before I've looked much into details (so don't
take the questions too seriously; the answers might be obvious and I
might be barking up the wrong tree):

1. Did you reimplement an allocator for the dma_pool_* API?  Should it
   use vmem(9) instead or can that not handle the requests that it
   needs?

2. What's up with the restore_mode property?  Does anything set it?
   What's the protocol?  Why isn't this needed by all the other
   drivers, which can already gracefully handle exiting X?

3. Why all the logic in vmwgfxfb.c duplicating genfb?  Why not just
   use genfb via drmfb, like the other major drm drivers use (i915,
   radeon, nouveau, amdgpu)?