Re: vfs_lockf changes (was: CVS commit: src)

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

Hi ad@,

Good to see you again!

On Tue, Sep 12, 2023 at 12:29 AM Martin Husemann <martin%netbsd.org@localhost> wrote:
>
> On Sun, Sep 10, 2023 at 02:45:53PM +0000, Andrew Doran wrote:
> > Module Name:  src
> > Committed By: ad
> > Date:         Sun Sep 10 14:45:53 UTC 2023
> >
> > Modified Files:
> >       src/common/lib/libc/gen: radixtree.c
> >       src/sys/kern: init_main.c kern_descrip.c kern_lwp.c kern_mutex_obj.c
> >           kern_resource.c kern_rwlock_obj.c kern_turnstile.c subr_kcpuset.c
> >           vfs_cwd.c vfs_init.c vfs_lockf.c
> >       src/sys/rump/librump/rumpkern: rump.c
> >       src/sys/rump/librump/rumpvfs: rump_vfs.c
> >       src/sys/sys: namei.src
> >       src/sys/uvm: uvm_init.c uvm_map.c uvm_readahead.c
> >
> > Log Message:
> > - Do away with separate pool_cache for some kernel objects that have no special
> >   requirements and use the general purpose allocator instead.  On one of my
> >   test systems this makes for a small (~1%) but repeatable reduction in system
> >   time during builds presumably because it decreases the kernel's cache /
> >   memory bandwidth footprint a little.
> > - vfs_lockf: cache a pointer to the uidinfo and put mutex in the data segment.
>
> Hi Andrew,
>
> most (all?) vfs_lockf tests are now crashing, e.g.
>
> https://netbsd.org/~martin/evbearmv7hf-atf/469_atf.html#failed-tcs-summary

Also:

(1) radix_tree_remove_node() calls kmem_free(9) in the softint context, by
which kernel crashes during install for anita:

https://releng.netbsd.org/b5reports/amd64/2023/2023.09.10.16.25.32/install.log

(2) tests in tests/net/altq fails (logs are not interesting, unfortunately):

https://netbsd.org/~martin/evbearmv7hf-atf/469_atf.html#net_altq_t_cbq_altq_cbq_basic_ipv4

I could reproduce (2) on other architectures as well.

Can you please take a look?

Thanks,
rin