tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: PowerBook 5xx instability fix.



> Date: Sun, 30 Mar 2025 11:29:38 +1100
> From: Nat Sloss <nathanialsloss%yahoo.com.au@localhost>
> 
> The attached patch fixes it and I'd like to commit it if there are no 
> objections.
> 
>  	maxaddr = high[numranges - 1] - m68k_ptob(1);
> -	high[numranges - 1] -= (m68k_round_page(MSGBUFSIZE) + m68k_ptob(1));
> +	high[numranges - 1] -= (m68k_round_page(MSGBUFSIZE) + m68k_ptob(8));

Please put a comment here explaining what's going on.

Is maxaddr still correct?  Should you apply the same substitution on
that line too?  If not, the comment must explain why maxaddr has
m68k_ptob(1) subtracted while high[numranges - 1] has m68k_ptob(8)
subtracted.


Home | Main Index | Thread Index | Old Index