Subject: Re: TCP/RFC 1323 bug
To: None <hwr@pilhuhn.de>
From: Jason Thorpe <thorpej@nas.nasa.gov>
List: tech-net
Date: 08/07/1999 07:12:22
On 7 Aug 1999 13:59:55 GMT
hwr@pilhuhn.de (Heiko W.Rupp) wrote:
> |to something like:
> |
> | if (opti.ts_present && opti.ts_ecr)
> |
> |to ensure that the timestamp is valid before using it to compute a
> |new RTO. That seems to have cured my particular problem and seems
> |like it should be used in the general case, as well (at least thats
> |my reading of the RFC!).
>
> Mine too. Interestingly, Stevens also describes code like ours
> (without the check) on page 938 of TCP/IP Illustrated 2.
I agree, as well. But is this incomplete? Seems like we want a macro
to encapsulate this test and use it everywhere opti.ts_present is tested,
yes? Othewise we could end up using bogus timestamp data for PAWS.
-- Jason R. Thorpe <thorpej@nas.nasa.gov>