Subject: Re: patch to align ip headers..
To: None <tech-net@netbsd.org>
From: Jason R Thorpe <thorpej@zembu.com>
List: tech-net
Date: 04/25/2000 21:35:44
On Wed, Apr 26, 2000 at 11:30:19AM +0900, itojun@iijlab.net wrote:
> >>+ if (mtod(m, intptr_t) & 0x3) {
> >>+ intptr_t i = mtod(m, intptr_t) & 0x3;
> >>+ bcopy(m->m_data, m->m_data - i, m->m_len);
> >Since the arguments overlap, that should be ovbcopy.
>
> just to be sure: there's no ovbcopy in the kernel any more.
> bcopy in the kernel is safe against overlap. (sys/lib/libkern/bcopy.c)
Better yet... memmove()! But I'm still not certain that this is actually
what we want to do.
--
-- Jason R. Thorpe <thorpej@zembu.com>